Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebRequestor methods refactoring #1109

Closed
nbartels opened this issue Dec 26, 2020 · 0 comments
Closed

WebRequestor methods refactoring #1109

nbartels opened this issue Dec 26, 2020 · 0 comments

Comments

@nbartels
Copy link
Contributor

With the access token as header field change, we had to add this String as additional parameter and this made the method signatures less structured. So we have to change this and provide a new WebRequestor.Request object that encapsulates all the possible parameters and provides some convenience methods to move some logic away from the DefaultWebRequestor.

This will improve the complexity and methods with less parameters are better ;)

But this is a breaking change as soon as you have a custom WebRequestor with your own executePost|Get|Delete methods.

@nbartels nbartels added this to the 4.0.0 milestone Dec 26, 2020
@nbartels nbartels self-assigned this Dec 26, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant