Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChangeValueFactory cannot handle a mention comment #1138

Closed
nbartels opened this issue Feb 26, 2021 · 0 comments
Closed

ChangeValueFactory cannot handle a mention comment #1138

nbartels opened this issue Feb 26, 2021 · 0 comments
Assignees
@nbartels
Labels
type: missing field/type
Milestone
3.15.0

Comments

@nbartels
Copy link
Contributor

If someone mentions a page in a comment, the webhook receives a JSON that cannot be converted by the ChangeValueFactory.

We have to handle this JSON and provide a new ChangeValue if it is not possible to use the mention post add value.
@nbartels nbartels added this to the 3.15.0 milestone Feb 26, 2021
@nbartels nbartels self-assigned this Feb 26, 2021
nbartels added a commit that referenced this issue Feb 27, 2021
@nbartels
Issue #1138 - MENTION_COMMENT_ADD added
c2635a7
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nbartels nbartels

Labels
type: missing field/type
Projects
None yet
Milestone
3.15.0
Development

No branches or pull requests
1 participant
@nbartels