Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CategorizedFacebookType #1143

Closed
nbartels opened this issue Mar 2, 2021 · 0 comments
Closed

Remove CategorizedFacebookType #1143

nbartels opened this issue Mar 2, 2021 · 0 comments
Assignees
@nbartels
Labels
type: cleanup
Milestone
2022.1.0

Comments

@nbartels
Copy link
Contributor

nbartels commented Mar 2, 2021

We used the CategorizedFacebookType as replacement for Page and User in some special cases and change the spots to use the new From object that contains the User and the Page object. So the type is no longer needed and we should remove it, because the major release allows us to do some breaking changes.
@nbartels nbartels added this to the 4.0.0 milestone Mar 2, 2021
@nbartels nbartels self-assigned this Mar 2, 2021
nbartels added a commit that referenced this issue Mar 2, 2021
@nbartels
Issue #1143 - made CategorizedFacebookType abstract
ff72f3c
@nbartels nbartels closed this as completed Mar 3, 2021
nbartels added a commit that referenced this issue Mar 6, 2021
@nbartels
Issue #1143 - made CategorizedFacebookType abstract
4e4a4df
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nbartels nbartels

Labels
type: cleanup
Projects
None yet
Milestone
2022.1.0
Development

No branches or pull requests
1 participant
@nbartels