Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IgMedia, the mdia_product_type is defined here and in the parent class. #1241

Closed
nbartels opened this issue Jul 29, 2022 · 0 comments
Closed

Fix IgMedia, the mdia_product_type is defined here and in the parent class. #1241

nbartels opened this issue Jul 29, 2022 · 0 comments
Assignees
@nbartels
Labels
type: cleanup
Milestone
2022.8.0

Comments

@nbartels
Copy link
Contributor

This belongs to the comment: b98ecfd#commitcomment-79457128

We have the field in both classes IgMedia and IgMediaChild where IgMedia extends the IgMediaChild class, so we can and should remove the field.
@nbartels nbartels added this to the 2022.8.0 milestone Jul 29, 2022
@nbartels nbartels self-assigned this Jul 29, 2022
nbartels added a commit that referenced this issue Jul 29, 2022
@nbartels
Issue #1241 - duplicated method removed from IgMedia
1086eb6
nbartels referenced this issue Jul 29, 2022
@nbartels
Issue #1198 - media_product_type added to IgMedia and some comments a…
b98ecfd 
…dded
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nbartels nbartels

Labels
type: cleanup
Projects
None yet
Milestone
2022.8.0
Development

No branches or pull requests
1 participant
@nbartels