Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: use time.Time instead of int64 #32

Open
dolmen opened this issue May 25, 2022 · 3 comments
Open

api: use time.Time instead of int64 #32

dolmen opened this issue May 25, 2022 · 3 comments

Comments

@dolmen
Copy link

dolmen commented May 25, 2022

Suggestion for API change: use time.Time instead of int64 in the exposed API. That would be more idiomatic.

@dolmen
Copy link
Author

dolmen commented Jun 7, 2022

@nightwolfz You voted against this proposal. Could you explain?

@yusufozturk
Copy link

I think in general using Epoch value is much safer. Quartz returns an interval value which is a total number of nanoseconds/milliseconds/seconds etc. So taking Epoch value as an input and adding quartz interval on top of it is much easier and safer option for the library.

With Epoch value, you can easily escape from timezone problems and It's very easy to convert time into the Unix time.

@yusufozturk
Copy link

A similar issue when timezone is in place:
#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants