Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing access to session doesn't work with custom sessionengine #1469

Open
ptman opened this issue Sep 4, 2019 · 2 comments
Open

testing access to session doesn't work with custom sessionengine #1469

ptman opened this issue Sep 4, 2019 · 2 comments
Labels
effort-unknown Needs more planning to determine waiting-for-reply Question raised, need answer
Projects
Revel

Comments

@ptman
Copy link
Contributor

ptman commented Sep 4, 2019

I have to do t.SessionEngine = InitRedisSessionEngine() in Before()
@brendensoares brendensoares added effort-unknown Needs more planning to determine waiting-for-reply Question raised, need answer labels Feb 8, 2020
@brendensoares
Copy link
Member

@ptman can you give me some more context? What should you be able to do?

@notzippy since you developed the session engine, do you have any insight?

@ptman
Copy link
Contributor Author

ptman commented Feb 8, 2020

I wrote a custom session engine. Sessions weren't working in tests.

revel/testing/testsuite.go

Line 49 in a3d7a7c

return NewTestSuiteEngine(revel.NewSessionCookieEngine())
always sets the default session engine, instead of the one configured.

@notzippy notzippy added this to To do in Revel May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort-unknown Needs more planning to determine waiting-for-reply Question raised, need answer
Projects
Revel
  
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptman @brendensoares