Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revel build command is generates unnecessary files #1513

Open
teitei-tk opened this issue Sep 25, 2020 · 2 comments
Open

revel build command is generates unnecessary files #1513

teitei-tk opened this issue Sep 25, 2020 · 2 comments

Comments

@teitei-tk
Copy link

I have created one simple Revel Application.

When I run the build command, it generates an unnecessary directory called target in application-path and a binary file in it. I read the code and could not figure out why.

Here are the steps to reproduce it.

https://github.com/teitei-tk/revel-cmd-example

$ git clone git@github.com:teitei-tk/revel-cmd-example.git $GOPATH/src/github.com/teitei-tk/revel-cmd-example
$ cd $GOPATH/src/github.com/teitei-tk/revel-cmd-example
$ revel build -a github.com/teitei-tk/revel-cmd-example/example/app -t /tmp/app
Revel executing: build a Revel application (e.g. for deployment)
Parsing packages, (may require download if not cached)... Completed
Your application has been built in: /tmp/app

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        example/app/target/

$ tree example/app/target
example/app/target
└── app
    └── github.com
        └── teitei-tk
            └── revel-cmd-example
                └── example
                    └── app
                        └── app
@goevexx
Copy link
Contributor

goevexx commented Sep 25, 2020

I was wondering as well why this folder is needed. And i am not getting much smarter reading the corresponding commits. First implementation seems to be here revel/cmd@f2b54f5#diff-20ea5d5c31c95ca96157da752b18a29a

@teitei-tk
Copy link
Author

Hmmm...

@notzippy This issue seems to have started with the code you committed. Do you know anything about this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants