Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock down version of reviewdog #33

Open
michaelglass opened this issue Dec 20, 2021 · 1 comment
Open

lock down version of reviewdog #33

michaelglass opened this issue Dec 20, 2021 · 1 comment
Labels
question Further information is requested

Comments

@michaelglass
Copy link

michaelglass commented Dec 20, 2021

Right now, there's a potential security vulnerability where a rogue commit to the reviewdog library would yield access to my whole codebase.

Is it possible to lock down the reviewdog ref in script.sh to avoid this?

(affects most reviewdog actions, but as brakeman is security-focused, I wanted to start here).

@mgrachev mgrachev added the question Further information is requested label Jan 8, 2022
@javierjulio
Copy link
Contributor

The reviewdog version is already an environment variable so to expose it as an input would be trivial. It could work just like the brakeman version input, where the blank default just implies using the hard coded default. Not sure if we want to implement this though since while the version could be changed the action may not support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants