Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: reviewdog/action-shellcheck
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.17
Choose a base ref
...
head repository: reviewdog/action-shellcheck
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.18
Choose a head ref
  • 6 commits
  • 4 files changed
  • 3 contributors

Commits on Apr 23, 2023

  1. Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    suzuki-shunsuke Shunsuke Suzuki
    Copy the full SHA
    b7f6d9f View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    1aefde2 View commit details

Commits on Jun 19, 2023

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    fdd6498 View commit details
  2. Merge pull request #52 from reviewdog/depup/reviewdog/reviewdog

    chore(deps): update reviewdog/reviewdog to 0.14.2
    shogo82148 authored Jun 19, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    1c58cf1 View commit details

Commits on Jun 21, 2023

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    be2fc41 View commit details
  2. Merge pull request #53 from reviewdog/migrate-actions-release

    ci: replace 'create-release action' with gh cli
    shogo82148 authored Jun 21, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    50e5e1e View commit details
Showing with 32 additions and 22 deletions.
  1. +1 −0 .gitattributes
  2. +18 −10 .github/workflows/release.yml
  3. +12 −11 README.md
  4. +1 −1 action.yml
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# Denote files that are shell scripts and should be normalized (convert crlf -> lf)
# and should be converted to unix line endings on checkout.
*.sh text eol=lf
non-sh-test text eol=lf
28 changes: 18 additions & 10 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -5,9 +5,13 @@ on:
- master
tags:
- 'v*.*.*'
pull_request:
types:
- labeled

jobs:
release:
if: github.event.action != 'labeled'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
@@ -33,15 +37,19 @@ jobs:
if_true: ${{ github.ref }}
if_false: ${{ steps.bumpr.outputs.next_version }}

# Create release.
- uses: actions/create-release@v1
if: "steps.tag.outputs.value != ''"
# Create release
- if: "steps.tag.outputs.value != ''"
env:
# This token is provided by Actions, you do not need to create your own token
TAG_NAME: ${{ steps.tag.outputs.value }}
CURRENT: ${{ steps.bumpr.outputs.current_version }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ steps.tag.outputs.value }}
release_name: Release ${{ steps.tag.outputs.value }}
body: ${{ steps.bumpr.outputs.message }}
draft: false
prerelease: false
run: |
gh release create "${TAG_NAME}" -t "Release ${TAG_NAME/refs\/tags\//}" --generate-notes --notes-start-tag "${CURRENT}"
release-check:
if: github.event.action == 'labeled'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Post bumpr status comment
uses: haya14busa/action-bumpr@v1
23 changes: 12 additions & 11 deletions README.md
Original file line number Diff line number Diff line change
@@ -115,14 +115,15 @@ jobs:

## Known issue

> Running `shellcheck.exe` on Windows might fail with the following error:
>
>`SC1017: Literal carriage return. Run script through tr -d '\r'`
>
> This is due to the presence of a carriage return character (`\r`) in the script.
>
> To fix this, you can add a `.gitattributes` file to your repository with the following contents:
> ```
> *.sh text eol=lf
> ```
> This will ensure that the scripts are checked out with the correct line endings.
Running `shellcheck.exe` on Windows might fail with the following error:

`SC1017: Literal carriage return. Run script through tr -d '\r'`

This is due to the presence of a carriage return character (`\r`) in the script.

To fix this, you can simply create or edit the `.gitattributes` file in the root of your repository with the following contents:

```
*.sh text eol=lf
```
This would ensure that the scripts are checked out with the correct line ending.
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
@@ -60,7 +60,7 @@ runs:
steps:
- uses: reviewdog/action-setup@v1
with:
reviewdog_version: v0.14.1
reviewdog_version: v0.14.2
- run: $GITHUB_ACTION_PATH/script.sh
shell: bash
env: