Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't seem to get warnings to show in yellow instead of red #1038

Closed
algojack opened this issue Aug 18, 2021 · 2 comments
Closed

Can't seem to get warnings to show in yellow instead of red #1038

algojack opened this issue Aug 18, 2021 · 2 comments

Comments

@algojack
Copy link

algojack commented Aug 18, 2021

Running this on github with golangci-lint i can't seem to get the warnings to show up in yellow like shown in first picture here: https://github.com/reviewdog/reviewdog#reporter-github-checks--reportergithub-pr-check
I tried using the reviewdog golangci-lint github action, tried to just install and run reviewdog by itself, tried changing settings in .golangci.yml and in .reviewdog.yml and in .github/workflows/reviewdog.yml. But while i tried all different levels (error, warning, info) none seem to be yellow like in that picture above. Anyone knows how to solve this?
tried github-pr-check and github-check reporters also.

@algojack
Copy link
Author

My coworker found the issue:

when you do --out-format line-number the word error, warning, etc doesn’t appear

so golangci-lint is not telling reviewdog the severity of any issues, and setting default severity: warning in the golangci-lint config doesn’t have any effect

So moving this ticket to the action-golangci-lint

@algojack
Copy link
Author

link for posterity: reviewdog/action-golangci-lint#110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant