Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests failing on master #174

Open
ianstormtaylor opened this issue Jul 31, 2014 · 2 comments
Open

tests failing on master #174

ianstormtaylor opened this issue Jul 31, 2014 · 2 comments

Comments

@ianstormtaylor
Copy link

Getting this on a fresh clone and install:

  3 passing (39ms)
  1 failing

  1) rework .toString() sourcemap option should inline sourcemap:

      AssertionError: expected 'body{color:red;}\n/*# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJzb3VyY2VzIjpbInNvdXJjZS5jc3MiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUEsS0FBTyIsInNvdXJjZXNDb250ZW50IjpbImJvZHkgeyBjb2xvcjogcmVkOyB9Il19 */' to be 'body{color:red;}\n/*# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjpudWxsLCJzb3VyY2VzIjpbInNvdXJjZS5jc3MiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUEsS0FBTyIsInNvdXJjZXNDb250ZW50IjpbImJvZHkgeyBjb2xvcjogcmVkOyB9Il19 */'
      + expected - actual

      +"body{color:red;}\n/*# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjpudWxsLCJzb3VyY2VzIjpbInNvdXJjZS5jc3MiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUEsS0FBTyIsInNvdXJjZXNDb250ZW50IjpbImJvZHkgeyBjb2xvcjogcmVkOyB9Il19 */"
      -"body{color:red;}\n/*# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJzb3VyY2VzIjpbInNvdXJjZS5jc3MiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUEsS0FBTyIsInNvdXJjZXNDb250ZW50IjpbImJvZHkgeyBjb2xvcjogcmVkOyB9Il19 */"

      at Assertion.prop.(anonymous function) (/Users/Storm/dev/ianstormtaylor/rework/node_modules/should/lib/should.js:61:14)
      at Context.<anonymous> (/Users/Storm/dev/ianstormtaylor/rework/test/rework.js:33:21)
      at callFn (/Users/Storm/dev/ianstormtaylor/rework/node_modules/mocha/lib/runnable.js:247:21)
      at Test.Runnable.run (/Users/Storm/dev/ianstormtaylor/rework/node_modules/mocha/lib/runnable.js:240:7)
      at Runner.runTest (/Users/Storm/dev/ianstormtaylor/rework/node_modules/mocha/lib/runner.js:373:10)
      at /Users/Storm/dev/ianstormtaylor/rework/node_modules/mocha/lib/runner.js:451:12
      at next (/Users/Storm/dev/ianstormtaylor/rework/node_modules/mocha/lib/runner.js:298:14)
      at /Users/Storm/dev/ianstormtaylor/rework/node_modules/mocha/lib/runner.js:308:7
      at next (/Users/Storm/dev/ianstormtaylor/rework/node_modules/mocha/lib/runner.js:246:23)
      at Immediate._onImmediate (/Users/Storm/dev/ianstormtaylor/rework/node_modules/mocha/lib/runner.js:275:5)
      at processImmediate [as _immediateCallback] (timers.js:374:17)
@MoOx
Copy link
Contributor

MoOx commented Aug 1, 2014

I got similar issue when playing with sourcemap for myth. I think it's related to a convert-source-map update.

eyJ2ZXJzaW9uIjozLCJmaWxlIjpudWxsLCJzb3VyY2VzIjpbInNvdXJjZS5jc3MiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUEsS0FBTyIsInNvdXJjZXNDb250ZW50IjpbImJvZHkgeyBjb2xvcjogcmVkOyB9Il19
give
{"version":3,"file":null,"sources":["source.css"],"names":[],"mappings":"AAAA,KAAO","sourcesContent":["body { color: red; }"]}

eyJ2ZXJzaW9uIjozLCJzb3VyY2VzIjpbInNvdXJjZS5jc3MiXSwibmFtZXMiOltdLCJtYXBwaW5ncyI6IkFBQUEsS0FBTyIsInNvdXJjZXNDb250ZW50IjpbImJvZHkgeyBjb2xvcjogcmVkOyB9Il19
give
{"version":3,"sources":["source.css"],"names":[],"mappings":"AAAA,KAAO","sourcesContent":["body { color: red; }"]}

It's just the "file" that is not here when set to null. That need to be fixed in test directly.

@lydell
Copy link
Contributor

lydell commented Aug 2, 2014

mozilla/source-map#104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants