Add geometry point_on_surface method #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@teeparham maybe you can merge this or @andrejreznik need to improve something? |
|
Thanks! It would be nice to add/fix the tests with floating point issues, but that can be done in a future PR. |
|
Released in 2.1.0. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the
Geometry#point_on_surfacemethod using GEOS CAPI. There is an implementation ofMultiPolygon#point_on_surfacealready in the master branch. So, this PR just move existed logic to base feature.Other Information
Other features like point and lines, not only polygons should have
point_on_surfacemethod. It would be more consistent. In PostGIS ST_PointOnSurface works fine with all feature types.