Fix last character of path prefix being deleted #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where the last letter of some verbatim prefixes are deleted if there are no more following path components. E.g. given the path `\\?\UNC\server\share` to_slash would produce `\\?\UNC\server\shar`.
|
Ohh, I misunderstood the spec of file path prefixes. Thank you for catching this! |
rhysd
approved these changes
Jan 15, 2021
|
And thank you for adding new test cases. That's super helpful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where the last letter of some verbatim prefixes are
deleted if there are no more following path components.
E.g. given the path
\\?\UNC\server\shareto_slashwould produce\\?\UNC\server\shar.Or more commonly
C:would produceC.I've added unit test coverage for some of the various Windows verbatim prefixes.