Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize error message #11

Closed
JCB-K opened this issue Jan 21, 2022 · 1 comment
Closed

Customize error message #11

JCB-K opened this issue Jan 21, 2022 · 1 comment

Comments

@JCB-K
Copy link
Contributor

JCB-K commented Jan 21, 2022

Hi!

Thanks for a great package :). Would you accept a PR that allows an optional config option for a custom error message? We want to adopt this package, but I'm afraid that the default message will nudge maintainers to just mock console.error as an easy way out, even when errors aren't expected. A custom error message would allow me to link to an internal documentation page with our common errors and how to handle them.

@ValentinH
Copy link
Owner

Thank you for the kind words!
Yes I would accept such a PR 🙂

Moreover, if you have ideas to improve the default one in a way that would be more helpful for the community, you are welcome ! 🎉

JCB-K added a commit to JCB-K/jest-fail-on-console that referenced this issue Jan 24, 2022
JCB-K added a commit to JCB-K/jest-fail-on-console that referenced this issue Jan 24, 2022
KevinHerklotz added a commit that referenced this issue Jan 25, 2022
Add support for custom error messages (closes #9, closes #11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants