Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mockImplementation info to warning message. #9

Closed
SDRACK opened this issue Dec 17, 2021 · 1 comment · Fixed by #12
Closed

Add mockImplementation info to warning message. #9

SDRACK opened this issue Dec 17, 2021 · 1 comment · Fixed by #12

Comments

@SDRACK
Copy link

SDRACK commented Dec 17, 2021

I wonder if it's worth adding the info about mockImplementation from the readme (here) to the warning message this package throws?

I'm pretty new to Jest, and didn't pick that up from the existing error message:

If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error') and test that the warning occurs.

(An aside, love the package - it's been really helpful for us.)
@ValentinH
Copy link
Owner

Yes I think this could be nice. Would you like to create a PR for this?

JCB-K added a commit to JCB-K/jest-fail-on-console that referenced this issue Jan 24, 2022
@JCB-K
Add support for custom error messages (closes ValentinH#9, closes Val…
268cef7 
…entinH#11)
JCB-K added a commit to JCB-K/jest-fail-on-console that referenced this issue Jan 24, 2022
@JCB-K
Add support for custom error messages (closes ValentinH#9, closes Val…
912b86a 
…entinH#11)
JCB-K added a commit to JCB-K/jest-fail-on-console that referenced this issue Jan 24, 2022
@JCB-K
Add support for custom error messages (closes ValentinH#9, closes Val…
50da84b 
…entinH#11)
@JCB-K JCB-K mentioned this issue Jan 24, 2022
Merged
KevinHerklotz added a commit that referenced this issue Jan 25, 2022
@KevinHerklotz
Merge pull request #12 from JCB-K/custom-error-message
4a0d817 
Add support for custom error messages (closes #9, closes #11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for custom error messages (closes #9, closes #11) JCB-K/jest-fail-on-console
2 participants
@ValentinH @SDRACK