Add support for custom error messages (closes #9, closes #11) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinH
approved these changes
Jan 24, 2022
|
Thanks for this. As soon as I retrieve my admin rights (I left the ricardo-ch org) I'll merge this 🙈 |
|
Let me know if you want me to merge it 😉 |
|
Yes, please go ahead @KevinHerklotz 🙏 ❤️ |
|
@KevinHerklotz could you cut a new version as well? I guess a commit like this needs to be done before @ValentinH can do the NPM release |
|
Yes you are right 🙈 |
|
It was finally published as v2.2.0 ! Sorry for the delay 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #11 , this PR adds support for custom error message. I also changed the default error message and added
mockImplementationthere, which should close #9.