fix: refactor to prevent the tear down check issue #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHerklotz
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13
The "Test did not tear down" check logic has been a source of problems recently. This check was in place to ensure that some code in a test could not disable the whole
failOnConsole()logic for the other tests. This was actually obsolete since #5 since we are now resetting the mechanism before each test: if one test somehow disables it, it will be enabled again in the next test.While digging again in this code, I now understand that having the fail on console mechanism enabled in a
beforeEach()and disabled in aafterEach()allows to simplify quite a lot the original logic. This is what this PR is about.The code in this PR is published as
2.2.2-alpha.0if you want to try it.