Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Standard Dependency #124

Closed
kyeotic opened this issue Jul 12, 2016 · 8 comments
Closed

Update Standard Dependency #124

kyeotic opened this issue Jul 12, 2016 · 8 comments

Comments

@kyeotic
Copy link

kyeotic commented Jul 12, 2016

Standard is looking to move to version 8 soon. This package is still on 5.4.1.

Whats the timeline for updating this package to keep pace with standard?

@ricardofbarros
Copy link
Owner

Hey @tyrsius I could update, but as of 3.4.0, this package will use the standard bellow your project's node_modules

@kyeotic
Copy link
Author

kyeotic commented Jul 13, 2016

Ah, that's probably why atom starts throwing errors when i npm prune --production for integration tests

@feross
Copy link

feross commented Jul 23, 2016

Related issue: standard/standard#574

@feross
Copy link

feross commented Jul 25, 2016

@ricardofbarros Any reason not to keep the standard dep reasonably up-to-date?

@ricardofbarros
Copy link
Owner

ricardofbarros commented Jul 26, 2016

Hey @feross, I wanted to move out from having standard, semistandard, etc. as dependencies of this package, because some times the windows users have some problems installing this package because of the path size. I think the issue of atom package's having a long path is already widespread and it's being discussed actively.

My idea was to slowly move to the approach of using the projects node_modules standard bin or if there isn't a node_modules directory check the user's PATH for the standard, semistandard, etc.

@feross
Copy link

feross commented Jul 26, 2016

Sounds like a reasonable approach. I think it would be better to remove the standard dep entirely though, so it doesn't revert back to standard v5 when users don't have a local copy installed.

@ghost
Copy link

ghost commented Aug 14, 2016

I believe the windows long path issues has been fixed some time ago with newer npm releases. I like the idea to prefer my local node modules.

But remove it entirely? I don't think that's a good idea, since we have to install standardjs global to be able use it for non nodejs javascript code, right?

@ricardofbarros
Copy link
Owner

I've updated all linter and custom parsers deps on the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants