Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestContainers instantiation - Deprecated constructor #26

Open
JoeSeff opened this issue Feb 22, 2021 · 1 comment
Open

TestContainers instantiation - Deprecated constructor #26

JoeSeff opened this issue Feb 22, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@JoeSeff
Copy link

JoeSeff commented Feb 22, 2021

  1. Pull the code
  2. Run the test in testcontainers-youtube-series

Context (Environment)

Java 11
Ubuntu 20.04

Solution

Change the constructor and provide the image name.

image
@JoeSeff JoeSeff changed the title TestContainers instantiation - Depreacted constructor TestContainers instantiation - Deprecated constructor Feb 22, 2021
@rieckpil
Copy link
Owner

rieckpil commented Feb 22, 2021 •
edited

thanks a lot for this finding @JoeSeff - I must have overseen this when bumping the Testcontainers version. If you want you can contribute (fork the repo, commit a change, and create a PR) to fix it :)

@rieckpil rieckpil added enhancement New feature or request good first issue Good for newcomers labels May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoeSeff @rieckpil