Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(alerts): add ability to close the Create Alert dialog from steps 2 and 3 #4860

Closed
ericpgreen2 opened this issue May 8, 2024 · 0 comments · Fixed by #4929
Closed

Fix(alerts): add ability to close the Create Alert dialog from steps 2 and 3 #4860

ericpgreen2 opened this issue May 8, 2024 · 0 comments · Fixed by #4929
Assignees
@AdityaHegde

Comments

@ericpgreen2
Copy link
Contributor

  • It should be possible to close the dialog from steps 2 and 3.
  • An attempt to close the dialog from steps 2 and 3 should be met with a confirmation dialog, e.g. "Are you sure you want to leave this alert? Your changes will not be saved."
@mindspank mindspank changed the title Alerts: add ability to close the Create Alert dialog from steps 2 and 3 Fix(alerts): add ability to close the Create Alert dialog from steps 2 and 3 May 13, 2024
@AdityaHegde AdityaHegde mentioned this issue May 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdityaHegde AdityaHegde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add support for cancelling alert create/edit from any tab rilldata/rill
2 participants
@AdityaHegde @ericpgreen2