Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"select_dtmcontrol", "select_dbus" and other variables should be per target #1001

Open
JanMatCodasip opened this issue Jan 23, 2024 · 0 comments

Comments

@JanMatCodasip
Copy link
Collaborator

JanMatCodasip commented Jan 23, 2024

Note to self: Discovered by code review that the following variables should be unique per each target (not globals shared by all RISC-V targets):

  • select_dtmcontrol
  • select_dbus
  • select_idcode
  • select_dbus

Reason: There can be different JTAG instruction lengths in each target (num_bits). See: https://github.com/riscv/riscv-openocd/blob/riscv/src/target/riscv/riscv.c#L454

The below variables (related to BSCAN tunneling, and currently also shared by all RISC-V targets) should be reviewed whether they need the same treatment:

  • bscan_tunnel_type
  • bscan_tunnel_ir_width
  • bscan_tunnel_ir_id
  • ir_user4
  • bscan_tunneled_ir_width
  • _bscan_tunnel_data_register_select_dmi
  • _bscan_tunnel_nested_tap_select_dmi

See: https://github.com/riscv/riscv-openocd/blob/riscv/src/target/riscv/riscv.c#L53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant