Minor issue: Different error message on removal of non-existent breakpoint

[MarekVCodasip]

Due to differences between vanilla and riscv-openocd, there is a different error message printed when removing non-existent breakpoint on SMP vs non-SMP targets. (Difference manifests on non-SMP)

Non SMP target:
Error during removal of breakpoint at address (addr)

SMP target:
no breakpoint at address (addr) found

See src/target/breakpoints.c:335 for more details.

[aap-sc]

@MarekVCodasip , @en-sc in my opinion the commit that introduced this discrepancy is rather controversial . I believe it was @timsifive who introduced the change, though.

Does anyone know what was the reason for introducing this and why the patch is not in the upstream openocd?

[aap-sc]

To be clear, i'm talking about this commit: 39a4f37

[TommyMurphyTM1234]

Does the discussion on the relevant PR help at all?

• target/breakpoints: Clear software breakpoints from available targets #879

[aap-sc]

@TommyMurphyTM1234 actually it does :). To my surprise I've already asked a question regarding the upstream changes. #879 (comment) O_o. And even got a reply (and acknowledged it). LOL. So basically there is a chunk of functionality related to unavailable target support which is not (or was not) upstreamed at the time.

Looking at the current code now - I have minor concerns that it may be difficult to upstream this specific functionality.