Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login not working on Safari #309

Open
akath20 opened this issue Feb 5, 2020 · 2 comments
Open

Login not working on Safari #309

akath20 opened this issue Feb 5, 2020 · 2 comments

Comments

@akath20
Copy link
Member

akath20 commented Feb 5, 2020

Steps:

  • Open new private window in Safari
  • Click login
  • login with valid rit.edu email

What should happen:
Login button should change to create/approve buttons

What happens:
It still shows Login

Notes:
Works on FireFox

@billdybas
Copy link
Member

I believe this is because Safari Private mode does not support local storage which is where we store your access token.
https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_API#Private_Browsing_Incognito_modes

@akath20
Copy link
Member Author

akath20 commented Feb 5, 2020

That makes sense. Not worth fixing that I suppose. Personally, I am logged in to my personal gmail all the time, so instead of logging/switching profiles it's easier to view it in private mode, but if that's just a Safari Private Mode issue that's a very small impact of people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants