Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Move darkmode toggle to right side of navbar #71

Open
5 tasks
2nPlusOne opened this issue Oct 25, 2023 · 0 comments
Open
5 tasks

Task: Move darkmode toggle to right side of navbar #71

2nPlusOne opened this issue Oct 25, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request front-end good first issue Good for newcomers

Comments

@2nPlusOne
Copy link
Contributor

2nPlusOne commented Oct 25, 2023

Move darkmode toggle to right side of navbar

Description

The darkmode toggle is usually located at the top right of the navbar in most sites. Let's move the toggle from the bottom left of the footer to the top right of the navbar.

Subtasks

  • Move the element into the navbar at the end of the container with the links
  • If there is layout shift due to deferred rendering until the component mounts (see this), render an empty skeleton element in its place to prevent the shift. You would just modify the return value in the isMounted conditional from null to the empty placeholder.

Acceptance Criteria

  • The darkmode toggle is always visible at the top right of the navbar
  • There is no layout shift when the page loads
  • The darkmode toggle is focusable and selectable with the keyboard
@2nPlusOne 2nPlusOne added enhancement New feature or request front-end good first issue Good for newcomers labels Oct 25, 2023
@ashton-michelstein ashton-michelstein self-assigned this Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request front-end good first issue Good for newcomers
Projects
Status: In Review
Development

No branches or pull requests

2 participants