Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memcached came from nowhere #1

Open
askucher opened this issue Apr 23, 2014 · 3 comments
Open

memcached came from nowhere #1

askucher opened this issue Apr 23, 2014 · 3 comments

Comments

@askucher
Copy link

No description provided.

@rjz
Copy link
Owner

rjz commented Apr 24, 2014

Very true. It shouldn't be a requirement for using the library, but it's much easier to demonstrate retrieving session data from an accessible store rather than process memory.

If you're having specific difficulties, it would be great to get a little more detail for a diagnosis and fix. Otherwise I'd love to merge some, ah, clarification around the readme!

@leobenkel
Copy link

I am confused about the "Accessing session data" as well. Would be nice to have a more detailed tutorial !

rjz added a commit that referenced this issue Feb 22, 2017
Supertest-session's cookie jar exposes session cookies for inspection or
reuse in downstream tests. The library makes no presumptions about what
those tests might entail, however, so it's rather confusing to bring in
a specific session store.
@rjz
Copy link
Owner

rjz commented Feb 22, 2017

Thanks for the nudge, @wonay!

As session storage is outside the scope of this library, I think it may be best to simply drop that note from the README (See #25). The goal of the (rather confusing) original example was to show how to access cookies from supertest-session's cookie jar for reuse against a backend session store. But it seems enough to show how to get at them, and leave it up to individual applications to decide if (and how) take to it from there.

That said, store-specific tutorials sound like a fantastic idea! If anyone is working with a specific store and would be willing to link up (or PR a link to) an example, it might save others some setup time (and confusion).

rjz added a commit that referenced this issue Mar 1, 2017
Drops store example from README (#1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants