Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a non-NaN/non-Inf niched float wrapper #283

Open
Kixiron opened this issue Jul 6, 2022 · 5 comments · May be fixed by #483
Open

Add a non-NaN/non-Inf niched float wrapper #283

Kixiron opened this issue Jul 6, 2022 · 5 comments · May be fixed by #483
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.8

Comments

@Kixiron
Copy link

Kixiron commented Jul 6, 2022

Being able to take advantage of float niches when you know the floats are non-NaN and/or non-Inf would be really useful
@djkoloski
Copy link
Collaborator

It looks like we could provide 3 bytes of niching for 32-bit floats, and a little over 6.5 bytes for 64-bit floats. Do you have an example of the kinds of values you'd want to niche?

@Kixiron
Copy link
Author

Kixiron commented Jul 6, 2022

What do you mean?

@djkoloski
Copy link
Collaborator

I assume you want to store some extra data in the non-exponent bits when the exponent is all ones, right? It doesn't really matter what data you want to store, but I'm interested in the use case.

@Kixiron
Copy link
Author

Kixiron commented Jul 6, 2022

Ah, currently I've just got an Option<f64> so it's not particularly interesting, I could probably pack some more stuff into it if I wanted to though

@djkoloski
Copy link
Collaborator

Ah, that makes sense. Seems like a reasonable wrapper.

@djkoloski djkoloski added enhancement New feature or request good first issue Good for newcomers labels Aug 9, 2022
@djkoloski djkoloski added this to the v0.8 milestone Mar 10, 2024
@novacrazy novacrazy linked a pull request Mar 24, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.8
Development

Successfully merging a pull request may close this issue.

Option<Float> Niche optimization novacrazy/rkyv
2 participants
@djkoloski @Kixiron