Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation Detector hides all Throwables from its users by catching Throwable #27

Open
halfmanhalffish opened this issue Nov 4, 2014 · 0 comments

Comments

@halfmanhalffish
Copy link

In private void detect(final ClassFileIterator iterator) there's a catch (Throwable) which can and will catch any exception that is thrown from users' Reporter classes. This makes it harder for users to write correct code, since problems will be hidden from them.
This applies to version 3.0.4. I didn't check version 3.1.

Call Hierarchy:
reportTypeAnnotation(Class<? extends Annotation>, String) : void readAnnotations(DataInput, char) : void - eu.infomas.annotation.AnnotationDetector readAttributes(DataInput, char, boolean) : void - eu.infomas.annotation.AnnotationDetector detect(DataInput) : void - eu.infomas.annotation.AnnotationDetector detect(ClassFileIterator) : void - eu.infomas.annotation.AnnotationDetector detect() : void - eu.infomas.annotation.AnnotationDetector detect(File...) : void - eu.infomas.annotation.AnnotationDetector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants