Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select onChange is called 3 times #854

Open
EmiBemi opened this issue Mar 1, 2023 · 3 comments
Open

Select onChange is called 3 times #854

EmiBemi opened this issue Mar 1, 2023 · 3 comments
Labels

Comments

@EmiBemi
Copy link
Member

EmiBemi commented Mar 1, 2023

  • What RMWC Version are you using [major.minor.patch]: 8.0.5

  • Name your build system [Webpack, Rollup...]: CRA

  • Describe the bug with as much detail as possible:
    To see the bug:

  1. go to https://rmwc.io/select-menus
  2. scroll down to Controlled / Uncontrolled
  3. open developer tool and the console
  4. switch between the options
  5. observe that the value is being console.log'ed 3 times
@kintz09
Copy link
Contributor

kintz09 commented Aug 23, 2023

I ran into this bug in our projects this week and can confirm its occurring. We are using version 8.0.5, 8.0.6, 8.0.7, and 8.08 in a create react app v4 react typescript project.

Here is a video I recorded demoing this bug using the documentation website. I verified it occurs with both controlled and uncontrolled instances.

Do we know if this bug is caused by RMWC or could it be a bug in the Material package?

@kintz09
Copy link
Contributor

kintz09 commented Aug 23, 2023

Here is the changelog for @Material 8.0.0.

It looks like something about change events was fixed:

select: Deduplicate change events (4ad1274), closes material-components/material-components-web#5570
select: do not emit change event when same value selected twice (e07a708)

I don't see any other bug fixes related to change events in versions after 8.0.0 so I wouldn't think this is a material bug, but maybe those issues linked above can help us determine the cause of this bug.

@jensborch jensborch added the bug label Jan 3, 2024
@jensborch
Copy link
Member

This is still an issue, additionally the select documentation is somewhat broken see #1254 and #1252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants