Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃挕 FEATURE REQUEST]: Add requeue tag to failed task metric of Jobs plugin #1566

Open
Kaspiman opened this issue May 20, 2023 · 2 comments
Assignees
Labels
C-feature-request Category: feature requested, but need to be discussed help-heeded-medium Call for participation: Experience needed to fix: Medium / intermediate

Comments

@Kaspiman
Copy link
Sponsor

Plugin

JOBS

I have an idea!

I have an idea, listen to me!

I suggest to add requeue param to failed task metric. We have rr_jobs_jobs_err metric in Jobs plugin and could be added tag requeue = 0 || 1 or another metric like rr_jobs_jobs_requeue.

Then we can observe finally failed tasks from requeued ones.

@Kaspiman Kaspiman added the C-feature-request Category: feature requested, but need to be discussed label May 20, 2023
@Kaspiman Kaspiman changed the title [馃挕 FEATURE REQUEST]: [馃挕 FEATURE REQUEST]: Add requeue param to failed task metric of Jobs plugin May 20, 2023
@Kaspiman Kaspiman changed the title [馃挕 FEATURE REQUEST]: Add requeue param to failed task metric of Jobs plugin [馃挕 FEATURE REQUEST]: Add requeue tag to failed task metric of Jobs plugin May 20, 2023
@Kaspiman
Copy link
Sponsor Author

If possible, I'd like to do this task myself. I鈥檓 just looking for simple practical tasks for learning the Go @rustatian

@rustatian
Copy link
Member

rustatian commented May 22, 2023

Hey @embargo2710 馃憢馃徎
This FR is not accepted yet, I have to think if we need the metric for the number of re-queued jobs, since we still won't be able to distinguish them from errors.
If you wanted some task for learning purposes, you may take this one: #909 (update CORS handler https://github.com/rs/cors in this small middleware: https://github.com/roadrunner-server/headers)

@rustatian rustatian added the help-heeded-medium Call for participation: Experience needed to fix: Medium / intermediate label Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: feature requested, but need to be discussed help-heeded-medium Call for participation: Experience needed to fix: Medium / intermediate
Projects
Status: 馃搵 Backlog
Development

No branches or pull requests

2 participants