Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[馃Ч CHORE, API]: Use oneof for the option protobuf message #1703

Open
1 task done
rustatian opened this issue Sep 1, 2023 · 0 comments
Open
1 task done

[馃Ч CHORE, API]: Use oneof for the option protobuf message #1703

rustatian opened this issue Sep 1, 2023 · 0 comments
Assignees
@rustatian
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..

Comments

@rustatian
Copy link
Member

No duplicates 馃ゲ.

  • I have searched for a similar issue.

What should be improved or cleaned up?

Currently we have a bloated Options message with different fields related to different, unrelated drivers. This doesn't matter from a speed perspective (unused fields don't cost anything), but it does matter from a proto-message architecture perspective.
Replace the contents of the options message with `one of' for the different drivers (AMQP, Kafka, etc).
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Sep 1, 2023
@rustatian rustatian self-assigned this Sep 1, 2023
@rustatian rustatian added this to the v2024 milestone Sep 1, 2023
@rustatian rustatian removed this from the v2024.1.0 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustatian rustatian

Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
Jira 馃槃
Status: 馃搵 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rustatian