Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃挕 FEATURE REQUEST]: musl arm64 binary [blocked by GitHub ARM action runners] #1875

Open
YOU54F opened this issue Feb 22, 2024 · 4 comments
Assignees
Labels
A-ci Area: CI CD C-feature-accepted Category: Feature discussed and accepted

Comments

@YOU54F
Copy link

YOU54F commented Feb 22, 2024

Plugin

None

I have an idea!

Hello related to #258

could you please, if possible publish musl arm64 variants of the roadrunner & protoc-gen-php-grpc

I maintain a project written in rust, which creates shared libraries which client libraries can load.

We have recently published musl based artifacts, and I am trying to integrate with pact-php's test suite, but one example requires roadrunner.

The AMD64 test run with the current musl binaries is green 馃帀 , I just require ARM64 binaries to get a full green build for my ARM64 test runs.

I can skip the test for now, but I noted you have existing arm64 binaries so I would hope it's not a big ask.

Happy to drop in a PR if you wish.

Thanks all!
Saf

@YOU54F YOU54F added the C-feature-request Category: feature requested, but need to be discussed label Feb 22, 2024
@rustatian
Copy link
Member

Hey @YOU54F 馃憢
Sure, I'll update the build pipeline 馃槂

@rustatian rustatian removed the C-feature-request Category: feature requested, but need to be discussed label Feb 22, 2024
@rustatian rustatian assigned rustatian and unassigned rustatian Feb 22, 2024
@rustatian rustatian added C-feature-accepted Category: Feature discussed and accepted A-ci Area: CI CD labels Feb 22, 2024
@YOU54F
Copy link
Author

YOU54F commented Feb 22, 2024

cheers my good man!

@rustatian rustatian added this to the v2023.3.12 milestone Feb 22, 2024
@rustatian
Copy link
Member

@YOU54F 馃憢
I expected that GitHub already have arm64 Ubuntu images... Only private beta exists, atm. btw, we're not using CGO, so I think you can use linux-arm64 binaries until GitHub publishes the arm64 action runners.

@rustatian rustatian removed this from the v2023.3.12 milestone Feb 27, 2024
@rustatian rustatian changed the title [馃挕 FEATURE REQUEST]: musl arm64 binary [馃挕 FEATURE REQUEST]: musl arm64 binary [blocked by GitHub ARM action runners] Feb 27, 2024
@rustatian rustatian changed the title [馃挕 FEATURE REQUEST]: musl arm64 binary [blocked by GitHub ARM action runners] [馃挕 FEATURE REQUEST]: musl arm64 binary [blocked by GitHub ARM action runners] Feb 27, 2024
@YOU54F
Copy link
Author

YOU54F commented Feb 27, 2024

Ahh yes, there is a private beta

https://resources.github.com/devops/accelerate-your-cicd-with-arm-and-gpu-runners-in-github-actions/

I've signed up but awaiting an invite.

I try and use qemu where possible to build for arm64 with docker, but I've actually tested with a few golang projects and the linux built executables work fine on alpine without a specific musl flavour (built and released with goreleaser) so will test out the regular linux-arm64 binaries.

Cheers for the having a look buddy, appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: CI CD C-feature-accepted Category: Feature discussed and accepted
Projects
Status: 馃敄 Ready
Development

No branches or pull requests

2 participants