You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Both WD5 and WD4 have support for notification streams. Basically this is a HTTP GET call that is kept-alive and keeps receiving JSON updates about thermostats.
Where do we put this code, ojmicroline.py is currently responsible for data-fetching, however since both WD4 and WD5 are pretty different (1 call vs 3 calls), im not sure where to put it. @adamjernst any suggestions?
Then we need to figure out what HA requires for these push updates. I think we need to implement something like registration for listeners and callbacks to those listeners?
I'm not sure but my first impulse is to add a method to the OJMicrolineAPI protocol, but keep most of the actual code in the respective WD5 and WG4 classes (which live in separate files). Use shared helper methods for any similar functionality.
i.e. keep ojmicroline.py pretty dumb and simple, and all the loop/keepalive management/etc in the wd5/wg4 classes, especially since the two models are so different
I think we need to implement something like registration for listeners and callbacks to those listeners?
Good question. I am not sure what the most Pythonic way to represent this is with asyncio. I guess check out some HA integrations that do similar push stuff and copy their approach?
There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!
robbinjanssen
added
no-stale
This issue or PR is exempted from the stable bot.
and removed
stale
There has not been activity on this issue or PR for quite some time.
labels
Mar 28, 2024
Both WD5 and WD4 have support for notification streams. Basically this is a HTTP GET call that is kept-alive and keeps receiving JSON updates about thermostats.
ojmicroline.py
is currently responsible for data-fetching, however since both WD4 and WD5 are pretty different (1 call vs 3 calls), im not sure where to put it. @adamjernst any suggestions?For WD5 this is a POC:
The text was updated successfully, but these errors were encountered: