Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression on a fix regarding propertiesAreEqualToIgnoring and handling nullable ignoringProperties #299

Open
benjaminserguienko opened this issue Jan 29, 2024 · 2 comments
Open

Regression on a fix regarding propertiesAreEqualToIgnoring and handling nullable ignoringProperties #299

benjaminserguienko opened this issue Jan 29, 2024 · 2 comments

Comments

@benjaminserguienko
Copy link

Hi,

A fix by @jakub-bochenski, that should allow nullable properties in propertiesAreEqualToIgnoring is not working as intended.

We noticed that this commit: c71f66c that should have fixed this issue has not been completely merged in this commit: 02f4226.

Can you please, fix this ? ty
@jakub-bochenski
Copy link
Contributor

I think its merged in d64444a

@jakub-bochenski
Copy link
Contributor

hmm.. indeed it seems the merge is not correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakub-bochenski @benjaminserguienko