Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify release ID instead of tag #551

Closed
kevcube opened this issue Nov 4, 2022 · 5 comments
Closed

Ability to specify release ID instead of tag #551

kevcube opened this issue Nov 4, 2022 · 5 comments

Comments

@kevcube
Copy link
Contributor

kevcube commented Nov 4, 2022

Is your feature request related to a problem? Please describe.
I have a workflow that outputs a release ID and for higher precision I'd like to use this instead of the tag to identify a release

Describe the solution you'd like
An input for release ID

Describe alternatives you've considered
I can just pass the tag

Additional context
I can probably PR this but haven't looked at the code yet.

@robinraju
Copy link
Owner

robinraju commented Nov 4, 2022

@kevcube If you prefer submitting a PR, you can add release_id to the outputs by making the following changes

add field id to

export interface GithubRelease {
name: string
tag_name: String
assets: GhAsset[]
tarball_url: string
zipball_url: string
}

And set the additional output release_id using the id field along

core.setOutput("tag_name", ghRelease.tag_name)

Here is a sample JSON where we get release id from:

@kevcube
Copy link
Contributor Author

kevcube commented Dec 3, 2022

@robinraju I'm looking to add release ID to the inputs of this workflow, not outputs. working on that now.

@kevcube
Copy link
Contributor Author

kevcube commented Dec 3, 2022

see #563

@robinraju
Copy link
Owner

robinraju commented Dec 3, 2022

@kevcube I just merged #563 you may test it by using this action from the merged commit as follows until the next version is released.

- uses: robinraju/release-downloader@63a56bcf84060d864b165ef03efbb696d1a8f066
  with:
    releaseId: "123123"
    fileName: "foo.zip"

Edit: The above commit hash is from a fix I merged in #564 Its tested and works fine now.

@robinraju
Copy link
Owner

A new version is released which contains this feature

- uses: robinraju/release-downloader@v1.7
  with:
    releaseId: "123123"
    fileName: "foo.zip"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants