New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecassarily large types in Datetime #32

Open

bhansconnect opened this issue Feb 1, 2024 · 0 comments

Labels

enhancement good first issue

Collaborator

bhansconnect commented Feb 1, 2024

Some reason, we use I128 for each of the values in this struct:

basic-webserver/platform/InternalDateTime.roc

Line 9 in d592b4e

    
           DateTime : { year : I128, month : I128, day : I128, hours : I128, minutes : I128, seconds : I128 }

This feels exceptionally large for no reason. We should analyze what is required and minimize the waste here.

bhansconnect added enhancement good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment