Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mocha #6

Open
sokra opened this issue Dec 5, 2017 · 5 comments
Open

Upgrade mocha #6

sokra opened this issue Dec 5, 2017 · 5 comments

Comments

@sokra
Copy link

sokra commented Dec 5, 2017

(+) 2 vulnerabilities found
 Name    Installed   Patched                        Path                                                                          More Info
 debug   2.6.8       >= 2.6.9 < 3.0.0 || >= 3.1.0   jest-runner-mocha@0.4.0 > mocha@3.5.0 > debug@2.6.8   https://nodesecurity.io/advisories/534
 growl   1.9.2       >=1.10.2                       jest-runner-mocha@0.4.0 > mocha@3.5.0 > growl@1.9.2   https://nodesecurity.io/advisories/146

Maybe you shouldn't use pinned dependencies in your package.json.

@ljharb
Copy link
Collaborator

ljharb commented Dec 5, 2017

Please don’t use mocha 4+ tho; it drops support for older nodes.

@jehy
Copy link

jehy commented Jan 28, 2020

Current mocha version is 7+ already, I suppose it is time to drop support for old node versions and make a major release :)

@ljharb
Copy link
Collaborator

ljharb commented Jan 28, 2020

I'd prefer not to ever drop support for mocha 3; older nodes still need testing.

@jehy
Copy link

jehy commented Jan 28, 2020

I'd prefer not to ever drop support for mocha 3; older nodes still need testing.

Why not leave support for old mocha in 0.x version?

Mocha and jest currently only support node 8+ so dropping support in major versions makes sense to me. And even node 8 is currently running to end of life.

I am not talking about updates for the sake of updates - but mocha 3 misses some really great features - like handling unhandled exceptions, for example.

If you still think that it is not necessary - may be we can add option to inject custom mocha instance, for example? Or use it as a peerDependency and allow user to install any mocha version he wants?

jehy added a commit to jehy/jest-runner-mocha-next that referenced this issue Jan 28, 2020
@ljharb
Copy link
Collaborator

ljharb commented Jan 28, 2020

EOL is irrelevant; node's support of a version has no direct bearing on users' use of it.

(You can handle unhandled exceptions manually using onUncaughtException in node in any mocha version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants