-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mocha #6
Comments
Please don’t use mocha 4+ tho; it drops support for older nodes. |
Current mocha version is 7+ already, I suppose it is time to drop support for old node versions and make a major release :) |
I'd prefer not to ever drop support for mocha 3; older nodes still need testing. |
Why not leave support for old mocha in 0.x version? Mocha and jest currently only support node 8+ so dropping support in major versions makes sense to me. And even node 8 is currently running to end of life. I am not talking about updates for the sake of updates - but mocha 3 misses some really great features - like handling unhandled exceptions, for example. If you still think that it is not necessary - may be we can add option to inject custom mocha instance, for example? Or use it as a peerDependency and allow user to install any mocha version he wants? |
EOL is irrelevant; node's support of a version has no direct bearing on users' use of it. (You can handle unhandled exceptions manually using |
Maybe you shouldn't use pinned dependencies in your package.json.
The text was updated successfully, but these errors were encountered: