Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal expand/collapse? #81

Open
nielskrijger opened this issue Feb 16, 2022 · 3 comments
Open

Horizontal expand/collapse? #81

nielskrijger opened this issue Feb 16, 2022 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@nielskrijger
Copy link

nielskrijger commented Feb 16, 2022

Thanks for the great library! I've been using it all over in one of my projects.

I was wondering, would it be complex to add a horizontal (width) based collapse effect?

I'm thinking of a sidebar expanding/collapsing.

If you're interested, I could have a look at creating a PR (if I find the time 😅 ); but before I do I'd love to hear if you'd even consider merging a feature like that and if you have any requirements/pointers regarding code.

Regards, Niels

@roginfarrer
Copy link
Owner

If it doesn't add too much complexity, you're welcome to take a shot at it! I haven't dug into animating width in a long time, but I think it could be as simple as swapping out height for width (when measuring and manipulating properties)

@roginfarrer roginfarrer added enhancement New feature or request help wanted Extra attention is needed labels Feb 20, 2022
@SaidMarar
Copy link

SaidMarar commented Dec 24, 2022

Hey guys 😃
Check the PR above i added the horizontal mode, please do not hesitate if you have any suggestions.
expand-collapse
@nielskrijger @roginfarrer

@codepath2019
Copy link

Hi 👋 I've noticed that the last activity on this PR was a few months ago, @roginfarrer and @SaidMarar, are there any plans to merge this change in? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants