testscript: relax constraints around actual source in cmp with update #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM with one trivial typo. Thanks! |
myitcv
force-pushed
the
testscript_relax_cmp_constraints
branch
from
b31249b
to
4d976e3
Compare
mvdan
approved these changes
Jul 31, 2020
There are currently constraints on the actual source for a failed cmp comparison when Params.UpdateScripts is true: the actual must be either stdout or stderr. However it's unclear why this constraint is necessary. Indeed it's a painful constraint when the actual source in a comparison is file written by a previous command. Relax this constraint because, after discussion with @mvdan and @rogpeppe, we believe it is safe to do so. Add a test for this new logic where the actual is a file that is part of the archive.
myitcv
force-pushed
the
testscript_relax_cmp_constraints
branch
from
4d976e3
to
28c666f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently constraints on the actual source for a failed cmp
comparison when Params.UpdateScripts is true: the actual must be either
stdout or stderr.
However it's unclear why this constraint is necessary.
Indeed it's a painful constraint when the actual source in a comparison
is file written by a previous command.
Relax this constraint because, after discussion with @mvdan
and @rogpeppe, we believe it safe to do so.
Add a test for this new logic where the actual is a file that is part of
the archive.