Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support emitting source map for Joiner. #10

Open
Tracked by #441
hyf0 opened this issue Mar 6, 2024 · 3 comments
Open
Tracked by #441

Support emitting source map for Joiner. #10

hyf0 opened this issue Mar 6, 2024 · 3 comments

Comments

@hyf0
Copy link
Member

hyf0 commented Mar 6, 2024

Won't be hard and just port https://github.com/Rich-Harris/magic-string/blob/6f6cd52270fdc8b62b1b94c73a5d19ba37b3d4dd/src/Bundle.js#L85-L167 would be enough.

See https://github.com/rolldown-rs/string_wizard/blob/00ff3ef9bfd9f63dd0d932bafa69a411717c84fa/src/magic_string/source_map.rs#L13 for references.

This will also meet the #4 problem, but we could ignore it so far. I will try solve #4 in one go.

@hyf0
Copy link
Member Author

hyf0 commented Mar 6, 2024

@underfin Do you have time to help solving this issue? Or I will solve it this weekend.

@underfin
Copy link
Contributor

underfin commented Mar 8, 2024

Please hold it, it is unnecessary at now.

@hyf0
Copy link
Member Author

hyf0 commented Mar 8, 2024

Ok. Get it.

Sieluna added a commit to Sieluna/string_wizard that referenced this issue Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants