Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(replace): clearify plugin-replace delimiters typing #1013

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

krist7599555
Copy link
Contributor

@krist7599555 krist7599555 commented Oct 2, 2021

delimiters accept only pair of string. array of 3 or more element won't make any sense.

const pattern = delimiters
? new RegExp(
`${escape(delimiters[0])}(${keys.join('|')})${escape(delimiters[1])}${lookahead}`,
'g'
)
: new RegExp(`\\b(${keys.join('|')})\\b(?!\\.)${lookahead}`, 'g');

Rollup Plugin Name: @rollup/plugin-replace

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
delimiters accept only pair of string. array of 3 or more element won't make any sense.
@krist7599555 krist7599555 changed the title clearify plugin-replace delimiters typing docs(replace): clearify plugin-replace delimiters typing Oct 11, 2021
@krist7599555 krist7599555 reopened this Oct 11, 2021
@shellscape shellscape merged commit 36121f1 into rollup:master Oct 19, 2021
shellscape pushed a commit that referenced this pull request Oct 19, 2021

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
delimiters accept only pair of string. array of 3 or more element won't make any sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants