Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): allow explicity compilerOptions #1045

Merged
merged 1 commit into from Feb 23, 2022
Merged

fix(typescript): allow explicity compilerOptions #1045

merged 1 commit into from Feb 23, 2022

Conversation

jpoehnelt
Copy link
Contributor

@jpoehnelt jpoehnelt commented Nov 17, 2021

Rollup Plugin Name: typescript

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes
  • no

Breaking Changes?

  • yes
  • no

List any relevant issue numbers:

Description

Allow explicitly setting compiler options instead of using rest syntax. This is less confusing in documentation and rollup config. It is also less fragile.

An alternative (see rollup-plugin-typescript2) would be to pull all tsconfig overrides out.

{
...
tsconfigOverrides: {
    compilerOptions: {},
    include: [...]
  }
}

@shellscape
Copy link
Collaborator

shellscape commented Nov 18, 2021

Please explain the changes verbosely in the PR description. (Please edit your PR to add that) Changing how the options are presented to the user is a breaking change so this will be under a lot of scrutiny. Looks like you have some failing CI tests to consider as well.

@shellscape
Copy link
Collaborator

@jpoehnelt ping

Copy link
Member

@NotWoods NotWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, it looks like there are type errors causing CI to fail

@shellscape
Copy link
Collaborator

shellscape commented Jan 5, 2022

@jpoehnelt if this gets to 60 days without an update, we'll close this one as abandoned. Please have a look at the CI failures so we can proceed.

@shellscape shellscape merged commit 1c32990 into rollup:master Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants