Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inject,replace): add types for sourceMap option #1066

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

danielroe
Copy link
Contributor

@danielroe danielroe commented Dec 15, 2021

Rollup Plugin Name: replace, inject

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

Description

This PR adds types for the sourceMap option which is respected by both plugins but not currently included in the typing.

Sorry, something went wrong.

@danielroe
Copy link
Contributor Author

Happy to split this into two PRs if you prefer (which I think would make the PR title format check happier).

@shellscape shellscape changed the title fix(inject, replace): add types for sourceMap option fix(inject,replace): add types for sourceMap option Dec 15, 2021
@shellscape
Copy link
Collaborator

It was the space after the comma that made it unhappy 😄 All fixed

@shellscape shellscape merged commit 68f02c9 into rollup:master Dec 28, 2021
@shellscape
Copy link
Collaborator

thanks!

@danielroe danielroe deleted the fix/types-for-sourcemaps branch December 28, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants