fix(node-resolve): support node: protocol

[isker]

Rollup Plugin Name: node-resolve

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

#1120

Description

Imports with the node: protocol are currently undetected by this plugin.

Switch to using is-builtin-module, which handles this protocol and also submodule imports like fs/promises. Functionality is otherwise identical.

I confirmed the added test fails without the other changes in this PR.

[isker]

Apologies, but I changed the authorship on the commit and now CI needs a button press again.

[shellscape]

@guybedford I think this could use your input given that it's introducing resolution for a new (to rollup) protocol

[guybedford]

Seems good. Note we should really just cut out the dependency and use something like:

function isBuiltinModule (name) {
  if (name.startsWith('node:')) name = name.slice(5);
  return require('module').builtinModules.includes(name);
}

[shellscape]

@isker what are your thoughts on that suggestion?

[isker]

What are @lukastaegert’s thoughts? This solution was his suggestion: #1120 (comment).

[shellscape]

I took a look at the is-builtin-modules and builtin-modules deps (both sindre packages, both very small) and I don't see that there'd be a significant perf hit loading either in the global space. For now, I think we're safe to merge as-is. If we notice a performance issue or we get reports of per issues, an optimization would be to dynamically require/import that package in the future.

Since this does add new capability, I'm going to merge this as a new feat rather than fix.