New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@rollup/plugin-commonjs] Fails to bundle json-bigint #1130
Comments
There are some things that can be done from within the commonjs plugin to handle this situation better by default, but the main problem I see is with the bignumber.js package. This package provides both a CommonJS and an ES module entry point. However, the CommonJS entry is not "interchangeable" with the ES module entry because it just exports what is the default export of the ES module entry while the ES module entry has additional named exports. Still, the proper solution would be for the To work around the issue, you can specify |
@lukastaegert thanks!! I sent a PR with the changes you suggested, hopefully it gets merged. In the meantime I'm just adding a |
May also be related: #1047 |
Hey folks. This issue hasn't received any traction for 60 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it. ⓘ |
@rollup/plugin-commonjs
^21
and22.0.0-13
2.70.0
Expected Behavior
Run
npm ci && npm run build && node index.out.js
.It should print
Actual Behavior
Additional Information
The text was updated successfully, but these errors were encountered: