fix(dynamic-import-vars): parameter types for dynamicImportToGlob

[poyoho]

Rollup Plugin Name: {dynamic-import-vars}

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

I saw the code of dynamicImportToGlob, use case in plugin and I try to use the dynamicImportToGlob with (BaseNode, String), it call an error.

And I think the sourceString is just used to format error msg. The first params is the estree node use to generate glob pattern.

And I make the sourceString as any will pass in my use case. So I think this is a type error.

[shellscape]

Thanks for the PR. Per our policy, fixes require tests to be accepted. Please update the types test (https://github.com/rollup/plugins/blob/master/packages/dynamic-import-vars/test/types.ts) accordingly for this change.

[poyoho]

done

[shellscape]

Thanks. Can you update the PR description to include information on why the previous typing was incorrect, and why it needed to change? It's important for people referencing this PR from the changelog to be able to discern what the change was for. This is a breaking change because it's changing a function signature in the types, so it's important we document that well.

[poyoho]

I saw the code of dynamicImportToGlob, use case in plugin and I try to use the dynamicImportToGlob with (BaseNode, String), it call an error.

And I think the sourceString is just used to format error msg. The first params is the estree node use to generate glob pattern. So I send a PR try to fix it.

[shellscape]

Thanks for that info, that'll come in handy I'm sure.