fix(typescript): allow tslib peerDependency to be optional for npm and pnpm #1191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
@rollup/plugin-typescript
This PR contains:
Are tests included?
Testing this would be akin to testing npm.
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
tslib
from peerDependencies of typescript plugin #265Description
tslib
is an optional dependency and in a large set of projects goes completely unused (notably anything compiling with babel or which does not require use of the helpers).Historically,
yarn
andnpm
would warn for peerDependencies but not error, but as better package managers have fixed this mistake (most notablypnpm
) and worked their way into being industry defaults this behavior has shifted from minor-nuisance to build-breaking.This PR uses the spec
peerDependencyMeta
respected by bothnpm
andpnpm
to declare the tslib peerDependency as entirely optional.