-
-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pluginutils (via TypeScript plugin): Cannot find module 'estree' #1315
Comments
Seems like estree isn't part of the dependency tree at all. On the other hand, estree-walker is. Maybe that one should be used? It also exports a |
Good idea. I will see if I can prepare a PR that fixes this. |
Apparently, |
Ah, sorry, I just realized we have to search the NPM tree for With
With
This patch here seems guilty: ce0652d |
I would argue that pluginutils should have |
Agreed. Looking at the original PR, it looks like this change might have been an accident #616. |
I made a PR: #1320 |
* fix: Update dependency `@rollup/pluginutils` to ^5.0.1 pluginutils version 4 has a missing production dependency on `@types/estree`, which manifested itself in issue #1315. pluginutils v5.0.1 is now released that fixes this problem (via #1320). This patch updates all plugins that depend on pluginutils to use the fixed version. * fix(babel): Revert pluginutils update * fix(repo): Update remaining Rollup dependencies Co-authored-by: Lukas Taegert-Atkinson <lukas.taegert-atkinson@tngtech.com>
@rollup/plugin-typescript
I'm getting an error with the newest version of the TypeScript plugin. This did not happen before the Rollup 3 preparations.
How to reproduce:
npm install --save-dev typescript rollup @rollup/plugin-typescript
tsc --noEmit
.Expected Behavior
The typecheck succeeds.
Actual Behavior
TypeScript outputs the following error:
Additional Information
@rollup/plugin-typescript
still depends on@rollup/pluginutils
version^4.2.1
, while5.0.0
would be available. Maybe this is part of the issue?The text was updated successfully, but these errors were encountered: