Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build hangs indefinitely after updating TypeScript to 4.9.3 #1349

Closed
romainmenke opened this issue Nov 19, 2022 · 7 comments
Closed

Build hangs indefinitely after updating TypeScript to 4.9.3 #1349

romainmenke opened this issue Nov 19, 2022 · 7 comments

Comments

@romainmenke
Copy link

  • Rollup Plugin Name: @rollup/plugin-typescript
  • Rollup Plugin Version: 9.0.2
  • Rollup Version: 2.79.1 (but also happens in 3.x because it isn't related to rollup itself)
  • Operating System (or Browser): macos
  • Node Version: 16.x
  • Link to reproduction (⚠️ read below): TypeScript 4.9 csstools/postcss-plugins#714

Expected Behavior

Build does not hang

Actual Behavior

Build hangs

Additional Information

microsoft/TypeScript#51592

I've first updated an issue upstream at TypeScript because I am 99% sure that something changed when updating to 4.9.3.

But there is a non-zero change that @rollup/plugin-typescript is using an API that subtly changed and is causing the issue.

Something that seemed harmless to change in TypeScript.

Cross linking here to so that you are aware of the issue.

@shellscape
Copy link
Collaborator

Thanks for opening an issue. Citing the issue template:

🚨 Issues WITHOUT a valid reproduction WILL BE CLOSED!

Please provide one by:

  1. Using the REPL.it plugin reproduction template at https://repl.it/@rollup/rollup-plugin-repro
  2. Provide a minimal repository link (Read https://git.io/fNzHA for instructions).
    Please use NPM for installing dependencies!
    These may take more time to triage than the other options.
  3. Using the Rollup REPL at https://rollupjs.org/repl/

⚠️ ZIP Files are unsafe and maintainers will NOT download them.

We cannot make this any clearer. Please add a reproduction and we'll be happy to triage further.

@romainmenke
Copy link
Author

romainmenke commented Nov 19, 2022

We cannot make this any clearer. Please add a reproduction and we'll be happy to triage further.

yeah.... this is not helping anyone @shellscape
This is a complex issue which happens in a large project.

I've made it clear that I do not expect you to spend time on this and that I am simply cross linking because I was asked to by the maintainers of TypeScript.

Being aware of issues is important.

Having a template that isn't always possible to be followed doesn't help anyone in getting anything resolved.


The reproduction is very simple though:

this satisfies 2. Provide a minimal repository link

This can not be reproduced out of context.

@romainmenke
Copy link
Author

@shellscape can you re-open this issue?
The template was followed and there are reproduction steps in my last comment.

@shellscape
Copy link
Collaborator

shellscape commented Nov 23, 2022

  1. Provide a minimal repository link (Read https://gist.github.com/Rich-Harris/88c5fc2ac6dc941b22e7996af05d70ff for instructions).

Your monorepo doesn't satisfy the requirement. If you can't reproduce it outside of that monorepo then you'll have to triage and/or provide the fix. We simply lack the resources to take on issues that don't have a simple reproduction.

@romainmenke
Copy link
Author

I am not asking you to fix it.
I am asking you to acknowledge the issue.

@nicholas-ochoa
Copy link
Contributor

@romainmenke I'm also having the same problem, though it happens intermittently and locally and with different packages within my monorepo (tiny packages, though). Do you by chance use pnpm?

@romainmenke
Copy link
Author

We do not use pnpm.
For us it is also intermittently, around 75% of all builds.

I found that the TypeScript authors are more interested in this issue :)
So make sure to also share your case here : microsoft/TypeScript#51592

I reverted back to TypeScript 4.8 but have setup a branch where I am tracking the last changes.

https://github.com/csstools/postcss-plugins/pull/714/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

Can you the same or a similar patch to your dependencies to test with TypeScript from git?
Not something that is really recommended but it will allow you to check if TypeScript 5.0 will cause issues or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants