feat(typescript): add transformers factory #1668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shellscape Would you mind reviewing this? |
|
@Haringat I'm backed up at work. will be end of the week before I circle back to open source. |
|
@shellscape what calendar are we going with? |
|
I'm using the Julian calendar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name: typescript
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves #1667
Description
This allows creating custom transformers in the typescript plugin together ahead-of-time in a factory function. This allows for shorter rollup configs in certain cases and enables using similar factory-style transformers like the angular compiler API.
This also cleans up a few places minor internals in the typescript plugin (missing parameter descriptions, deprecated APIs, generic identifiers)