Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt updated rollup-plugin-delete? #1685

Open
2 tasks done
NullVoxPopuli opened this issue Feb 19, 2024 · 2 comments
Open
2 tasks done

Adopt updated rollup-plugin-delete? #1685

NullVoxPopuli opened this issue Feb 19, 2024 · 2 comments

Comments

@NullVoxPopuli
Copy link

NullVoxPopuli commented Feb 19, 2024

Request Checklist:

New Plugin Use Case

cleaning the output directory before building is very nice for multi-entrypoint packages and helping prevent accidental cache issues with delete modules (which otherwise wouldn't get deleted in the output directory)

New Plugin Proposal

plugin already exists, very low maintenance required.
it's basically a one line plugin around the del package.

See also: KineticCafe/rollup-plugin-delete#15

@shellscape
Copy link
Collaborator

Thanks for raising the request. Our policy is basically to wait for a request from a maintainer or to wait until they give the thumbs up. Typically we ask that someone "sponsors" the package by volunteering to maintain it once it enters the repo here, but like you said this is a small one. The only potential hangup I see here is that it's ESM-only. Most of the plugins here are written as JS with types shipped, because the types are pretty simple. I'd probably be more comfortable pulling in the original if vlad is OK with it, and writing an index.d.ts for it.

@halostatue
Copy link

@shellscape As the maintainer of the fork from Vlad's repo (because of TS2349), I'm happy to see this move upstream. I won't have time to convert my version back to JS and write a new index.d.ts for it in the next little while (probably until June). I also don't see myself (long-term) having time to sponsor this package.

If someone else wants to take on the re-translation / sponsorship effort, I'm happy to review code and test it in our project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants